Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core/plugin)!: inline result type alias #8037

Merged
merged 2 commits into from
Oct 17, 2023
Merged

refactor(core/plugin)!: inline result type alias #8037

merged 2 commits into from
Oct 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 17, 2023 •
edited
Loading

avoid multiple result aliases when a user searches on docs.rs

continuation of #7875

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 17, 2023 16:19
@amrbashir amrbashir changed the title refactor(core/plugin): inline result type alias refactor(core/plugin)!: inline result type alias Oct 17, 2023
@lucasfernog lucasfernog merged commit 1490567 into dev Oct 17, 2023
1 of 2 checks passed
@lucasfernog lucasfernog deleted the chore/inline-result-type branch October 17, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog